Add mobile Shift+Tab hotkey#20
Open
ZacharyZcR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add Shift as a mobile terminal keyboard modifier and expose Shift+Tab as a selectable hotkey.
\x1b[ZChanges Made
shiftandshiftTabtoALL_KEYSso they appear in keyboard customization.KeyboardBartoggle Shift and send reverse-tab when Shift is active and Tab is pressed.Related Issues
Screenshots / Demos
Not included; this should be verified on Android/iOS by opening the terminal keyboard and sending Shift+Tab to an SSH session.
Validation run locally:
npx eslint app/tabs/sessions/terminal/keyboard/KeyDefinitions.ts app/tabs/sessions/terminal/keyboard/KeyboardBar.tsx app/tabs/sessions/terminal/keyboard/CustomKeyboard.tsx app/tabs/sessions/Sessions.tsxpasses with existingSessions.tsxwarnings only.npx prettier --check app/tabs/sessions/terminal/keyboard/KeyDefinitions.ts app/tabs/sessions/terminal/keyboard/KeyboardBar.tsx app/tabs/sessions/terminal/keyboard/CustomKeyboard.tsx app/tabs/sessions/Sessions.tsxpasses.git diff --checkpasses.npx tsc --noEmitstill fails on existing repository-wide TypeScript errors outside this change.Checklist