Skip to content

fix: VRL chat persistence and review tab scroll #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TerrifiedBug merged 3 commits into from
Mar 11, 2026
Merged

fix: VRL chat persistence and review tab scroll #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20e98c6
fix: VRL chat persisting old conversations and review tab scroll broken
TerrifiedBug Mar 11, 2026
4559019
fix: match sample dropdown text size to toolbar buttons
TerrifiedBug Mar 11, 2026
01613b5
fix: prevent VRL editor from closing when switching browser tabs
TerrifiedBug Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions src/app/api/ai/vrl-chat/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,24 +84,15 @@ export async function POST(request: Request) {
let priorMessages: Array<{ role: "user" | "assistant"; content: string }> = [];

if (!conversationId) {
// Reuse existing conversation for this pipeline + component if one exists
const existing = await prisma.aiConversation.findFirst({
where: { pipelineId: body.pipelineId, componentKey: body.componentKey },
orderBy: { createdAt: "desc" },
select: { id: true },
// Always create a new conversation — the client loads existing ones via TRPC query
const conversation = await prisma.aiConversation.create({
data: {
pipelineId: body.pipelineId,
componentKey: body.componentKey,
createdById: session.user.id,
},
});
if (existing) {
conversationId = existing.id;
} else {
const conversation = await prisma.aiConversation.create({
data: {
pipelineId: body.pipelineId,
componentKey: body.componentKey,
createdById: session.user.id,
},
});
conversationId = conversation.id;
}
conversationId = conversation.id;
} else {
// Verify conversationId belongs to this pipeline + component
const existing = await prisma.aiConversation.findUnique({
Expand Down
2 changes: 1 addition & 1 deletion src/components/flow/ai-pipeline-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ export function AiPipelineDialog({
) : (
<>
{/* Message thread */}
<ScrollArea className="flex-1 pr-4">
<ScrollArea className="flex-1 h-0 pr-4">
<div className="space-y-4 pb-4">
{conversation.messages.length === 0 && !conversation.isStreaming && (
<p className="text-sm text-muted-foreground text-center py-8">
Expand Down
3 changes: 2 additions & 1 deletion src/components/vrl-editor/vrl-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ export function VrlEditor({ value, onChange, sourceTypes, pipelineId, componentK
<DialogContent
className="h-[85vh] flex flex-col sm:max-w-[calc(100vw-4rem)] xl:max-w-6xl"
onKeyDown={(e) => e.stopPropagation()}
onFocusOutside={(e) => e.preventDefault()}
>
<DialogHeader>
<DialogTitle>VRL Editor</DialogTitle>
Expand Down Expand Up @@ -615,7 +616,7 @@ export function VrlEditor({ value, onChange, sourceTypes, pipelineId, componentK
{pipelineId && upstreamSourceKeys && upstreamSourceKeys.length > 0 && (
<>
<Select value={String(sampleLimit)} onValueChange={(val) => setSampleLimit(Number(val))}>
<SelectTrigger className="h-8 w-[110px] text-xs">
<SelectTrigger className="h-8 w-[120px] text-sm">
<SelectValue />
</SelectTrigger>
<SelectContent>
Expand Down
Loading