Skip to content

fix(update-triage): treat maintainer login as additive #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Terry-Mao merged 1 commit into from
Jun 10, 2026
Merged

fix(update-triage): treat maintainer login as additive #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/skills/update-triage/scripts/aggregate_triage_feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,8 @@ def is_maintainer_signal(
return False
if is_bot_user(login, typename) and not include_bots:
return False
if maintainer_logins:
return login in maintainer_logins
if maintainer_logins and login in maintainer_logins:
return True
if association in MAINTAINER_ASSOCIATIONS:
return True
if org_member_fallback:
Expand Down
6 changes: 3 additions & 3 deletions .github/aicodingflow-tests/test_aggregate_triage_feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,16 +276,16 @@ def test_org_member_fallback_uses_permission_cache(self) -> None:
)
)

def test_maintainer_login_allowlist_restricts_other_maintainers(self) -> None:
self.assertFalse(
def test_maintainer_login_adds_to_association_and_fallback_sources(self) -> None:
self.assertTrue(
aggregate.is_maintainer_signal(
repo="o/r",
login="other-maintainer",
association="OWNER",
maintainer_logins={"target-maintainer"},
)
)
self.assertFalse(
self.assertTrue(
aggregate.is_maintainer_signal(
repo="o/r",
login="other-maintainer",
Expand Down