Skip to content

my recent changes it has: optimized select rendering ,copy, paste, copy all, mousewheel , shortcut keys#24

Open
shimondoodkin wants to merge 31 commits intoTerryGeng:masterfrom
shimondoodkin:my-recent-changes
Open

my recent changes it has: optimized select rendering ,copy, paste, copy all, mousewheel , shortcut keys#24
shimondoodkin wants to merge 31 commits intoTerryGeng:masterfrom
shimondoodkin:my-recent-changes

Conversation

@shimondoodkin
Copy link
Contributor

@shimondoodkin shimondoodkin commented Dec 9, 2023

shortcut keys : control c = copy , control v = paste, esc =deselect

@shimondoodkin
Copy link
Contributor Author

it has copy, paste, copy all, mousewheel , shorcut keys control c = copy , control v = paste, esc =deselect

@shimondoodkin shimondoodkin changed the title my recent changes my recent changes it has copy, paste, copy all, mousewheel , shorcut keys control c = copy , control v = paste, esc =deselect Dec 9, 2023
@shimondoodkin shimondoodkin changed the title my recent changes it has copy, paste, copy all, mousewheel , shorcut keys control c = copy , control v = paste, esc =deselect my recent changes it has copy, paste, copy all, mousewheel , shorcut keys Dec 9, 2023
@shimondoodkin shimondoodkin changed the title my recent changes it has copy, paste, copy all, mousewheel , shorcut keys my recent changes it has copy, paste, copy all, mousewheel , shortcut keys Dec 9, 2023
@shimondoodkin shimondoodkin changed the title my recent changes it has copy, paste, copy all, mousewheel , shortcut keys my recent changes it has: optimized select rendering ,copy, paste, copy all, mousewheel , shortcut keys Dec 9, 2023
@TerryGeng
Copy link
Owner

TerryGeng commented Dec 9, 2023

Again, thanks for your contribution. I appreciate your time and effort.

I'm aware that you are trying to consolidate all changes into the same PR. In other larger projects to which I have submitted PRs, this move is not welcomed. On this tiny project, I'm still fine with it. What I hope is to have a clear commit history. This involves using git rebase instead of git merge (you may want to change the default merge option of your git pull). Also, for any changes you did and un-did in the commit history of this PR, you may use git rebase -i to reformulate the commit history and get rid of those.

I understand you have limited time. I can also work on cleaning up this PR whenever I have a chance.

@shimondoodkin
Copy link
Contributor Author

shimondoodkin commented Dec 10, 2023

I can recreate changes from your branch again. I have all the changes in separate branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants