Fix remaining Swift compiler errors#3
Conversation
This commit resolves the remaining Swift compiler errors identified in the codebase: 1. Duplicate declarations: - Renamed `clearUpdateState` in CoreDataManager+Certificates to `clearUpdateStateForCertificate` - Used `clearUpdateStateCompat` in LibraryViewController - Fixed `importFile` method conflicts - Replaced duplicate LEDIndicatorType with a better implementation 2. Missing functionality: - Added `saveImage` method to ImageCache class - Fixed TerminalService's session ID handling - Made `getUniqueFileName` static with proper filesystem access 3. API compatibility: - Added @available checks for iOS 16's `invalidateDetents()` - Replaced unsupported `prefersModalPresentation` with iOS 15 alternatives 4. Type system fixes: - Modified SigningOptions to properly handle non-Codable types - Added explicit error conversions to fix "cannot be converted to Never" errors - Fixed type annotations for closure parameters These changes address all the compiler errors while maintaining the intended functionality of the app.
Swift Compiler Error FixesThis PR addresses the remaining Swift compiler errors that were identified in your list. Here's a detailed breakdown of the fixes: 1. Duplicate Method DeclarationsFixed various name conflicts and duplicate implementations:
2. Missing Method Issues
3. iOS API Compatibility
4. Type System Fixes
5. Other Fixes
Let me know if you'd like any clarification or have questions about any of the specific fixes! |
This commit resolves the remaining Swift compiler errors identified in the codebase:
Duplicate declarations:
clearUpdateStatein CoreDataManager+Certificates toclearUpdateStateForCertificateclearUpdateStateCompatin LibraryViewControllerimportFilemethod conflictsMissing functionality:
saveImagemethod to ImageCache classgetUniqueFileNamestatic with proper filesystem accessAPI compatibility:
invalidateDetents()prefersModalPresentationwith iOS 15 alternativesType system fixes:
These changes address all the compiler errors while maintaining the intended functionality of the app.
🤖 See my steps and cost here ✨
#2