Fix structural issues in Swift code

[mentatbot]

This commit addresses Swift compiler errors related to code structure and organization:

1. Fixed LibraryViewController's structural issues:

   • Extracted search-related code to LibraryViewController+SearchExtensions.swift
   • Extracted UI action methods to LibraryViewController+UIActions.swift
   • Fixed indentation and missing brace closure issues
   • Renamed method calls to match their new locations

2. Fixed self reference in AppDelegate+NetworkMonitoring:

   • Added explicit 'self.' reference to connectionTypeToString call in closure

3. Fixed button target in HomeViewController:

   • Updated to use @selector(performFileImport) instead of importFile

4. Fixed type conversion issues in TerminalViewController:

   • Fixed Void->String conversion error by handling success case properly
   • Resolved optional binding issues with baseURL by creating a local variable

These changes restructure the code to comply with Swift's scope and visibility rules while maintaining the original functionality.

---

🤖 See my steps and cost here ✨

#2

• Wake on any new activity.

[mentatbot]

Fix Structural Issues in Swift Code

This PR addresses several Swift compiler errors related to code structure, scope, and organization. These errors were reported from the most recent workflow run.

Key Structural Changes

1. Reorganized LibraryViewController Code

The main issue with LibraryViewController was related to method declarations and extensions appearing in local scopes, which is invalid in Swift. To fix this:

• Created LibraryViewController+SearchExtensions.swift containing:

  • Search functionality methods
  • UISearchResultsUpdating implementation
  • Search controller setup code
  • Helper properties for search state

• Created LibraryViewController+UIActions.swift containing:

  • Alert display methods
  • Action handlers like showNoCertificatesAlert
  • Sheet presentation configuration methods
  • TableView extension methods that were incorrectly using override

This approach moves code from local scopes to file-level extensions, resolving the "Declaration is only valid at file scope" and "Attribute 'private' can only be used in a non-local scope" errors.

2. Fixed Self Reference in Closure

In AppDelegate+NetworkMonitoring.swift, there was a missing explicit self reference:

// Fixed:
"connectionType": self.connectionTypeToString(connectionType)

This resolves the "Call to method in closure requires explicit use of 'self'" error.

3. Fixed Button Target Selector

Updated HomeViewController's button setup to match the renamed method:

// Changed from:
HomeViewUI.uploadButton.addTarget(self, action: #selector(importFile), for: .touchUpInside)
// To:
HomeViewUI.uploadButton.addTarget(self, action: #selector(performFileImport), for: .touchUpInside)

This fixes the "Cannot find 'importFile' in scope" error.

4. Fixed Type Conversion in TerminalViewController

The TerminalViewController had two type-related issues:

• Fixed Void-to-String conversion error by properly handling the success case:

  case .success:
      // Result is Void, no output to display from HTTP mode
      break

• Fixed conditional binding issue with baseURL by creating a local variable:

  let serverBaseURL: String
  if let baseURL = TerminalService.shared.baseURL {
      serverBaseURL = baseURL
  } else {
      // Error handling
  }

Overall Improvements

These changes maintain the original functionality while significantly improving code structure by:

1. Properly separating concerns into extension files
2. Fixing scope and visibility issues
3. Following Swift's rules for extensions and method declarations
4. Correctly handling type conversions and optional bindings

The code is now properly structured according to Swift's scope and organization rules, which should resolve all the compiler errors from the workflow run.