Adding EqualsVerifier to test for validity of equals contract#243
Open
Inventitech wants to merge 2 commits intomasterfrom
Open
Adding EqualsVerifier to test for validity of equals contract#243Inventitech wants to merge 2 commits intomasterfrom
Inventitech wants to merge 2 commits intomasterfrom
Conversation
Adds an EqualsVerifier test to detect possible problems in our equals implementation. Purposefully breaks the build, as the contract is violated (test fails). Refs #230
Collaborator
|
I was able to fix the build in #268, so I think this PR is no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an EqualsVerifier test to detect possible problems in our equals implementation. Purposefully
breaks the build, as the contract is violated (test fails).
Refs #230