Recovered: fix(doctor): validate --output through the shared output-mode validator (#213 by @Yazan-O)

[jangjos-128]

Summary

doctor resolved the global --output flag directly (globals.output ?? 'text'), bypassing the shared validator every other command uses — so an invalid mode (e.g. --output yaml) silently fell through instead of producing the standard typed VALIDATION_ERROR.

This routes doctor's option resolution through resolveOutputMode and adds command-wiring coverage: invalid --output now yields the standard VALIDATION_ERROR; text and json still work.

4 lines of src change + tests.

Tests

• vitest run src/commands/doctor.test.ts — 14/14 pass
• npm run lint:fix, npm run typecheck, npm run build — pass
• Full npm test on this Windows host is blocked by the POSIX path/mode assumptions fixed in test: make the Windows CLI test harness portable #207 — the two PRs compose.

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of the doctor command’s output format so invalid values are rejected with a clear validation error.
  • Ensured valid output modes continue to work correctly, including both text and JSON results.

• Tests

  • Added coverage for command parsing and output-mode validation.
  • Verified successful report output in both text and JSON formats.

[coderabbitai]

Warning

Review limit reached

@jangjos-128, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ff9df9c-fcd4-4e87-87c2-626886d81e29

📥 Commits

Reviewing files that changed from the base of the PR and between 60d55e4 and cfd8783.

📒 Files selected for processing (2)

• src/commands/doctor.test.ts
• src/commands/doctor.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}