feat: add HasDependenciesOutside family to find types with dependencies outside an allowed set#333
Merged
Merged
Conversation
…cies outside an allowed set Implements the positive counterpart of the `DependOnlyOn` family (closes #328): - `ThatType.HasDependenciesOutside(...)` (namespaces and `Filtered.Types` targets) - `ThatTypes.HaveDependenciesOutside(...)` (sync and async enumerables) - `TypeFilters.WhichHaveDependenciesOutside(...)` The allowed set follows the same rules as `DependsOnlyOn`: sub-namespaces are included, the own namespace and framework assemblies never count as outside, and the results are chainable with `.OrOn(...)`, `.ExcludingSubNamespaces()` and `.ExcludingOwnSubNamespaces()`. Negated assertions report the offending dependencies via the shared `DependencyViolationRenderer`.
- Fix the README example asserting a legacy module: the plural assertion is all-quantified, so demonstrate the single-type assertion instead. - Extend the stale (for depends-only-on) remarks in the shared dependency options to mention the has-dependencies-outside family. - Mirror two only-on edge tests: a subject in the global namespace and the namespace-qualification of same-named violators in the negated message.
|
🚀 Benchmark ResultsDetails
|
👽 Mutation ResultsaweXpect.ReflectionDetails
The final mutation score is 92.35%Coverage Thresholds: high:80 low:60 break:0 |
|
This is addressed in release v2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the positive counterpart of the
DependOnlyOnfamily:ThatType.HasDependenciesOutside(...)(namespaces andFiltered.Typestargets)ThatTypes.HaveDependenciesOutside(...)(sync and async enumerables)TypeFilters.WhichHaveDependenciesOutside(...)The allowed set follows the same rules as
DependsOnlyOn: sub-namespaces areincluded, the own namespace and framework assemblies never count as outside,
and the results are chainable with
.OrOn(...),.ExcludingSubNamespaces()and
.ExcludingOwnSubNamespaces(). Negated assertions report the offendingdependencies via the shared
DependencyViolationRenderer.