docs: show verified failure messages for all three libraries in the comparison page#343
Merged
Merged
Conversation
🚀 Benchmark ResultsDetails
|
…ypes/repositoryTypes
|
|
This is addressed in release v2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The failure-messages section of the architecture comparison page listed an
Expect.ThatAlloutput with no source code and only described the other libraries' messages in prose.Because(…)reason) was captured from a real test run; the ArchUnitNETFailedArchRuleExceptionformat and xUnit'sAssert.True()output were checked against the respective sources.Expect.ThatAllexample with a one-sentence teaser linking to the full code + output example in the architecture-rules page.Rename layer selection variables
Rename
domain/infrastructure/repositoriestodomainTypes/infrastructureTypes/repositoryTypesin the architecture-rules page and the README. The variable name appears verbatim inExpect.ThatAllfailure messages, soExpected that domainTypes are all sealednow reads naturally (verified against a real test run).