Skip to content

opended PR on redpipe + updates on 215: developer fixed test [com.alicp.jetcache.anno.filed.CreateCacheTest.test]#103

Merged
darko-marinov merged 8 commits intoTestingResearchIllinois:mainfrom
SpiceOwlf:main
Oct 23, 2021
Merged

opended PR on redpipe + updates on 215: developer fixed test [com.alicp.jetcache.anno.filed.CreateCacheTest.test]#103
darko-marinov merged 8 commits intoTestingResearchIllinois:mainfrom
SpiceOwlf:main

Conversation

@SpiceOwlf
Copy link
Copy Markdown
Contributor

@SpiceOwlf SpiceOwlf commented Oct 18, 2021

WIP status for redpipe-templating-freemarker/checkTemplateNegociationDefault
I will update it once finish coding and open the PR.

@SpiceOwlf
Copy link
Copy Markdown
Contributor Author

SpiceOwlf commented Oct 18, 2021

I opened a pull request at FroMage/redpipe#54

@SpiceOwlf SpiceOwlf changed the title WIP status for redpipe-templating-freemarker/checkTemplateNegociationDefault Opened status for redpipe-templating-freemarker/checkTemplateNegociationDefault Oct 18, 2021
@SpiceOwlf
Copy link
Copy Markdown
Contributor Author

SpiceOwlf commented Oct 18, 2021 •
edited
Loading

Right now the PR is under my repository(SpiceOwlf/redpipe#1), I will make it against the real repository once I confirm the format with Professor/TA.

@SpiceOwlf
Copy link
Copy Markdown
Contributor Author

SpiceOwlf commented Oct 23, 2021

I updated the pull request, which is at FroMage/redpipe#56. Meanwhile, the checker is telling me that this link is not valid. How should I fix this checker error?

@SpiceOwlf
Update pr-data.csv
ba3e6ef 
-Remove "/"  from".../56/" 
and 
-changed "FroMage" to "fromage"
@SpiceOwlf
Copy link
Copy Markdown
Contributor Author

SpiceOwlf commented Oct 23, 2021

Hi, I made the fix and now the checker is happy with the format.

@SpiceOwlf
Update pr-data.csv
e8d9ccb 
developer seems to fix 215, com.alicp.jetcache.anno.filed.CreateCacheTest.test. It passes nondex test on my VM.
@SpiceOwlf SpiceOwlf changed the title Opened status for redpipe-templating-freemarker/checkTemplateNegociationDefault opended PR on redpipe + updates on 215: developer fixed test [com.alicp.jetcache.anno.filed.CreateCacheTest.test] Oct 23, 2021
@SpiceOwlf
Copy link
Copy Markdown
Contributor Author

SpiceOwlf commented Oct 23, 2021

Hi Professor, I ran Nondex on:
215
https://github.com/alibaba/jetcache
jetcache-test
com.alicp.jetcache.anno.filed.CreateCacheTest.test.
The test on latest master passes the Nondex, while the test on d28019640ac3eb6ac167dd0dc582adac7656226e did not. So I think the developer fixed this flaky test already. What else do I need to provide in this case?

@darko-marinov darko-marinov merged commit 16928aa into TestingResearchIllinois:main Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SpiceOwlf @darko-marinov