Otp feature#130
Draft
kalennyk wants to merge 5 commits into
Draft
Conversation
kalennyk
requested review from
AMartishyn-testlum,
bshakhov-testlum and
mykhailorudyk
Collaborator
|
As I see, the OTP code gets defined and saved in a variable at the moment of its declaration. And the test scenario depends on the expiration time of the OTP code - fetching it too early risks test flakiness. Tell me if I'm wrong but I guess the OTP code has to gets defined only on the actual usage of it, and should be just like the promise object |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.