Make flask resizable and keep water fill proportional#52
Merged
Testtesttestestes merged 1 commit intoMar 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
progress.Description
Flask WidthandFlask Heightand forwarded them intoRealisticProgressBarasflaskWidth/flaskHeightprops so the shape can be changed at runtime.flaskHalfSizeandflaskRadius, used when generating initial particle positions and when reinitializing the SPH simulation._flaskShapestate andsetFlaskShapeAPI insrc/sph/sph.jsand threadedu_flask_half_size/u_flask_radiusuniforms into the particle update and pressure passes.src/sph/renderer.js/src/sph/ms.frag) to accept the dynamic flask shape and use it for rendering/refraction, and updatedupdate.frag/pressure.fragto use the uniforms for collision, density and respawn logic so active particle count (controlled byu_progress) still represents the fill percentage.Testing
npm run buildwhich completed successfully.artifacts/flask-resizable.png(first attempt timed out, second run succeeded).Codex Task