Fix render speedup after simulation stalls/reconfiguration#54
Merged
Testtesttestestes merged 1 commit intoMar 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
lastTimewas set before async resource loading.Description
lastTimetonulland set it on the first animation frame to avoid computing a largedtfrom a stale timestamp (lastTime→nulland first-frame assignment).isDisposedflag and early returns after async initialization and at the start of the loop to prevent starting or continuing the loop after effect cleanup (isDisposedguard).kinematicPrevRefandreverseImpulseRefwhen the simulation is reinitialized to avoid carrying over stale kinematic state.Testing
npm run buildand the production build completed successfully (Vite build finished without errors).Codex Task