Feature/modernize pytorch#15
Open
eoffermann wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize PyTorch → 2.6 (+ CUDA 12.4) & Add CPU‑Only Support
This PR upgrades the entire PyTorch stack to the current 2.6 release, switches the CUDA wheels to 12.4, and introduces a standalone
requirements‑cpu.txtfor environments without a GPU. Along the way it fixes a few compatibility breaks that surfaced after the upgrade and removes an accidental binary blob.✨ What’s new
Python ≥3.9 is required by PyTorch 2.6 and PL 2.5.1.
The
rank_zero_onlyimport path change means plugins or downstream forks must update their imports if they referenced the old location.Any local environment caches need a full
pip install -r requirements.txt(orrequirements‑cpu.txt) after the merge.🔬 How I tested
Fresh GPU and CPU virtual‑env installs on Linux and macOS (Apple Silicon in CPU mode) complete without conflicts.
gen_wav.pyend‑to‑end inference runs on both CUDA 12.4 and CPU, generating identical audio outputs relative to pre‑upgrade samples.Unit tests for the diffusion modules pass with PL 2.5.1 and the new import paths.
🚀 Upgrade guide
GPU build (CUDA 12.4)
– or –
CPU build