fix: Sign In button always visible in both light and dark modes#182
Closed
texture-fleet-agent[bot] wants to merge 1 commit intomainfrom
Closed
fix: Sign In button always visible in both light and dark modes#182texture-fleet-agent[bot] wants to merge 1 commit intomainfrom
texture-fleet-agent[bot] wants to merge 1 commit intomainfrom
Conversation
SignInButton from @clerk/nextjs renders nothing until Clerk fully initializes. On mobile this meant the Sign In button was completely absent from the DOM — not a contrast issue, just missing. - Replace all SignInButton wrappers with plain <Link href='/sign-in'> - Works immediately on page load in both light and dark modes - No dependency on Clerk initialization timing - Add text-decoration: none to button-styled links
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Closing — superseded by #181 (merged) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sign In button was completely missing from mobile nav — not a contrast issue, the button was absent from the DOM entirely. Root cause:
<SignInButton>from@clerk/nextjsrenders nothing until Clerk fully initializes. On mobile where Clerk can be slow, the button never appeared.Fix
Replaced all
<SignInButton mode="modal">wrappers with plain<Link href="/sign-in">. The/sign-inroute already exists in the app, so this works immediately on page load — zero dependency on Clerk initialization.Changes
components/TopBar.tsx: Replace 3xSignInButton→Link(desktop nav, mobile top-bar, mobile drawer)app/globals.css: Addtext-decoration: noneto button-styled link classesSignInButtonimportWorks in both light and dark modes, renders immediately.
Co-authored-by: Nicholas Brown nicholasalanbrown@gmail.com