Conversation
|
Hey @SamuelQZQ! |
|
@21Chani ok, I will make sure to take a look today! |
|
hey @21Chani , I merged you recent pr, but finally found that it cannot pass the |
This reverts commit 5804b2f.
|
@21Chani I reverted this pr. Feel free to recreate it if you find out how to fix the bug. |
Lol really, i was sure that tests was passing... Thank you sir, doing my cardio rigjt now, will take a look why vector is breaking after it, my bad. |
|
@SamuelQZQ Just opened a new pr with the fix for it #246. I believe there will not be any issues anymore, if you can also run the tests just to confirm would be good. If we could allow the tests on pull requests from people that is not in the org would avoid this too. |
This PR will:
Refactor types aiming a new cleaner approach to make life easier when messing with abi type conversion.
Motivation
At #237 I found myself dealing with a lot troubles having to manage a refactor in files that shouldn't be touched in the pr, because of that I am splitting those small tasks to it's own pr's like this one.
Approaches explanation
I wanted to remove type conversions like this one that was being "recreated" in 3 files:

So I have created a map type for it that will provide type reusability and also easier type reading.

But I had to make it generic with
HighValuebecause I found that sometimes the api needs to usestringinstead ofAnyNumber, so, instead of creating two separated types, you just need to provide the type in generics of the type of Number return you want to manage.Example:
or