Skip to content

Add OpenSeaMap seamark layer#163

Merged
LabordePierre merged 2 commits intomainfrom
dev-162
Mar 9, 2026
Merged

Add OpenSeaMap seamark layer#163
LabordePierre merged 2 commits intomainfrom
dev-162

Conversation

@LabordePierre
Copy link
Copy Markdown
Contributor

Implement feature #162

Refactoring of shared cache key methods.
@LabordePierre LabordePierre self-assigned this Mar 4, 2026
@LabordePierre LabordePierre added the enhancement New feature or request label Mar 4, 2026
Comment thread src/GeoView-Examples/GeoViewExamples.class.st
Copy link
Copy Markdown
Contributor

@ELePors ELePors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor remarks and very interesting new features !

@labordep
Copy link
Copy Markdown
Contributor

labordep commented Mar 5, 2026

Hi, thanks.

For questions, I suggest to ask in dedicated issues (to not lost them), and we will change them into related tasks.

Appart your questions, what you request to change?

@ELePors
Copy link
Copy Markdown
Contributor

ELePors commented Mar 6, 2026

Hi, i was just suggesting to create a named variable for "defaultMaxScale" containing the 50000 value.
The method should be a way to describe why this value and the unit in method comments.
But as i said, it is minor and more descriptive than functional.

If not requested for this part of the code i can accept the pull request :)

Cheers,
Eric.

@LabordePierre
Copy link
Copy Markdown
Contributor Author

Hi, i was just suggesting to create a named variable for "defaultMaxScale" containing the 50000 value. The method should be a way to describe why this value and the unit in method comments. But as i said, it is minor and more descriptive than functional.

If not requested for this part of the code i can accept the pull request :)

Cheers, Eric.

Ok understood! This issue not concern this perimeter but I will check that. The default max value is 100000000 not 50000. 50000 is a setting do in the test.

+ Write an example to display scale infos (basic) to prepare feature #164
+ Fix bug #165
@LabordePierre LabordePierre requested a review from ELePors March 6, 2026 12:06
@LabordePierre LabordePierre added bug Something isn't working labels Mar 6, 2026
@LabordePierre LabordePierre merged commit f8ed6b4 into main Mar 9, 2026
13 checks passed
@LabordePierre LabordePierre deleted the dev-162 branch March 9, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants