Skip to content

Core/Player: Fix MAX_TITLE_INDEX calculation for title mask #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovahlord merged 2 commits into from
Feb 18, 2026
Merged

Core/Player: Fix MAX_TITLE_INDEX calculation for title mask #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dad793
Core/Player: Fix MAX_TITLE_INDEX calculation for title mask
gonzo1247 Feb 15, 2026
eef11e1
Core/Player: Replace sizeof-based bit calculation with explicit 64
gonzo1247 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/server/game/Entities/Player/Player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24916,7 +24916,9 @@ bool Player::isTotalImmune() const

bool Player::HasTitle(uint32 bitIndex) const
{
if (bitIndex > MAX_TITLE_INDEX)
// bitIndex is zero-based inside PLAYER__FIELD_KNOWN_TITLES.
// MAX_TITLE_INDEX is the total number of available bits (valid range: [0, MAX_TITLE_INDEX)).
if (bitIndex >= MAX_TITLE_INDEX)
return false;

uint32 fieldIndexOffset = bitIndex / 32;
Expand Down
3 changes: 2 additions & 1 deletion src/server/game/Entities/Player/Player.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,9 @@ static_assert((PLAYER_FIELD_BYTES_2_OFFSET_OVERRIDE_SPELLS_ID & 1) == 0, "PLAYER

constexpr uint8 PLAYER_BYTES_2_OVERRIDE_SPELLS_UINT16_OFFSET = PLAYER_FIELD_BYTES_2_OFFSET_OVERRIDE_SPELLS_ID / 2;

// KNOWN_TITLES is stored in 4 uint64 values, so we can represent 256 title bits (4 * 64).
constexpr uint8 KNOWN_TITLES_SIZE = 4;
constexpr uint32 MAX_TITLE_INDEX = KNOWN_TITLES_SIZE * sizeof(uint64); // 4 uint64 fields
constexpr uint32 MAX_TITLE_INDEX = KNOWN_TITLES_SIZE * 64;

// used in PLAYER_FIELD_BYTES values
enum PlayerFieldByteFlags
Expand Down
Loading