Properly initialize PackedGuid buffer#462
Merged
Ovahlord merged 3 commits intoThe-Cataclysm-Preservation-Project:masterfrom Mar 10, 2026
Merged
Properly initialize PackedGuid buffer#462Ovahlord merged 3 commits intoThe-Cataclysm-Preservation-Project:masterfrom
Ovahlord merged 3 commits intoThe-Cataclysm-Preservation-Project:masterfrom
Conversation
Ovahlord
merged commit 2e6bee2
into
The-Cataclysm-Preservation-Project:master
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
While debugging an issue where combo points were not updated on Windows builds, it turned out that
PackedGuid(ObjectGuid)did not value-initialize_packedGuidbefore calling Set().On MSVC debug builds this could leave
0xCCbytes in the unused part of the buffer. When packing GUIDs with only a few non-zero bytes (e.g. inSMSG_UPDATE_COMBO_POINTS), this could lead to malformed packed GUID data being serialized.This change value-initializes
_packedGuidin the constructor and resets the buffer inSet()to ensure deterministic behavior.The issue was only observed on Windows builds so far.
Tests performed: (Does it build, tested in-game, etc)
Compiles successfully on Windows (MSVC) and Linux.
In-game:
Tested combo point generation against training dummies. Combo points are now correctly updated on Windows builds.