Introduce PHPStan and PHPUnit infrastructure#4
Merged
Conversation
Integrated foundational development tooling into the Core repository by configuring PHPStan for static analysis and bootstrapping PHPUnit for testing. Updated the README to reflect these changes and outline branch-specific details. This setup establishes a baseline for static guarantees, type safety, and deterministic testing, supporting future CI/CD integration and long-term architectural goals.
1 task
Revised the `packagist` URL in the CITATION.cff file to reflect the correct namespace (`the-firehub-project/core-standard`). This ensures proper attribution and accurate package reference for external tools and repositories.
Configured PHPStan by introducing a `phpstan.neon` file and adding `phpstan/phpstan` and `the-firehub-project/phpstan-rules` as development dependencies in `composer.json`. Updated `.gitattributes` to exclude the configuration file from export. This enhances the repository with static analysis capabilities to ensure code quality and type safety.
Introduced a new GitHub Actions workflow (`PHPStan.yml`) to run static analysis on pull requests using PHPStan. The workflow leverages a reusable workflow for matrix execution across supported PHP versions, extensions, and tool configurations. This integration automates analysis for code quality and type safety, aligning with Core-Standard’s development practices.
Introduced a new GitHub Actions workflow (`PHPStan.yml`) to run static analysis on pull requests using PHPStan. The workflow leverages a reusable workflow for matrix execution across supported PHP versions, extensions, and tool configurations. This integration automates analysis for code quality and type safety, aligning with Core-Standard’s development practices.
dieselxxx
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🪛 Generic / Task Pull Request
Related Issue
Closes PHPStan and PHPUnit infrastructure #3
Description
This PR introduces foundational development tooling into the FireHub Core repository by integrating PHPStan for static analysis and PHPUnit for automated testing.
The goal is to establish a strict quality assurance baseline that ensures type safety, architectural consistency, and regression protection across the Core layer.
What this introduces
Base directory structure for tests
Purpose
This change introduces and formalizes the development-time quality infrastructure for the Core Standard repository using PHPStan.
It ensures that all Core components are validated before merge through a centralized static analysis setup, enforcing strict architectural and type-safety guarantees across the FireHub ecosystem.
This establishes a clear separation between:
Changes
Implementation
phpstan.neonconfiguration file for project-level static analysis setupPHPStan.ymlpull_request.gitattributes/phpstan.neon export-ignoreto exclude configuration from distribution artifactscomposer.json:phpstan/phpstanthe-firehub-project/phpstan-rules: dev-developDependencies
Added:
phpstan/phpstan:^2.0the-firehub-project/phpstan-rules:dev-developUpdated:
Compatibility
No runtime changes introduced. All changes are strictly development-time tooling and CI validation.
Testing
Verification
Automated Tests
Documentation
Checklist
Risks / Impact
Potential Impact
Areas Requiring Attention
phpstan.neonand shared FireHub rulesetdev-developbranch dependency forphpstan-rulesNotes
Technical Notes
.gitattributesensures tooling config does not leak into distribution artifactsReviewer Notes
Focus on:
phpstan-rules (dev-develop)