feat(live_ui): add AskSidebar widget Phoenix.Component (Wave 3.7-B Stage-4, DRAFT, Pascal-review REQUIRED)#138
Draft
ty13r wants to merge 2 commits into
Draft
feat(live_ui): add AskSidebar widget Phoenix.Component (Wave 3.7-B Stage-4, DRAFT, Pascal-review REQUIRED)#138ty13r wants to merge 2 commits into
ty13r wants to merge 2 commits into
Conversation
Stage 4 of the canonical ask_sidebar widget pipeline: - LiveUi.Widgets.AskSidebar Phoenix.Component with full render template - Recent rail (capped at 10, relative timestamps, running-status indicator) - Saved rail (★ glyph, cadence or last_run_at meta) - Map jump affordance with optional blocker-count badge - Scoped ARIA heading ids, aria-current on active row - 39 Stage-4 tests (all pass) Stages 1-3 were pre-committed by parallel Wave 3.7-B agents: - Stage 1 (IUR constructor): commit 95b0233 (ThreadCard batch) - Stage 2 (catalog entry): commit 95b0233 (ThreadCard batch) - Stage 3 (renderer clause): commit 931a440 (tree_view extension) DRAFT: 8 open questions for Pascal review flagged in @moduledoc. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Apply registry-threading discipline per the updated widget skill (project-ariston PR #62 + memory entry [[new-canonical-widget-needs- registry-threading]]). Mirrors Pascal's a902750 (PresenceDot) pattern. Touch points (delta): widgets aggregation (overlay.ex) + both adapters (iur_adapter + live_ui_adapter) + multi-layer tests (renderer, iur_adapter, live_ui_adapter). Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
5ebb45b to
32fdeb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 3.7-B canonical widget: AskSidebar — the Ask-mode sidebar shell that replaces
:sidebar_shellwhen the operator is in Ask mode.All 4 stages of the canonical widget pipeline are delivered (Stages 1–3 by parallel agents, Stage 4 by this PR):
UnifiedIur.Widgets.Components.ask_sidebar/1+:ask_sidebaradded to@layer_callout_kinds— committed in95b0233(ThreadCard batch)%{kind: :ask_sidebar, family: :layer_shell_and_callout, …}inunified_ui/widget_components.ex— committed in95b0233(ThreadCard batch)render(%{element: %Element{kind: :ask_sidebar}} = assigns)clause placed ABOVE generic@component_kindsfallback inlive_ui/renderer.ex— committed in931a440(tree_view extension)LiveUi.Widgets.AskSidebarmodule with full render template — this PRWidget contract
:sidebar_id,:on_map_jump_event:recent_items(list, cap 10),:saved_items(list),:active_item_id,:on_new_saved_event,:on_see_all_event,:empty_recent_label,:empty_saved_label,:blocker_count<aside data-live-ui-widget="ask-sidebar" aria-label="Ask sidebar"><section aria-labelledby="ask-recent-h-{id}">with relative timestamps + running-status indicator<section aria-labelledby="ask-saved-h-{id}">with ★ glyph + cadence/last_run_at meta<button aria-label="Switch to Map mode">with optional blocker-count badgeTests
packages/live_ui/test/live_ui/widgets/ask_sidebar_test.exs)95b0233alongside the constructorOpen questions for Pascal review
These 8 questions are flagged in the
@moduledocand gate the transition from DRAFT to ready-to-merge::sidebar_shell.:sidebar_shell: share CSS tokens or distinct?sb-bottom): part of widget contract or host-injected?Pre-flight findings
95b0233✓95b0233✓@component_kindsfallback): already committed931a440✓LiveUi.Widgets.FileTreeBrowser.componentreferenced in renderer.ex but Stage-4 module missing — not caused by ask_sidebar, pre-existing from95b0233Test plan
@moduledocwith decisions, remove open-questions section🤖 Generated with Claude Code