Implement canonical navigation phase 3 web runtime mapping#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
live_uicanonical screen-transition mapping and server-authoritative runtime navigation handlingelm_uiserver/runtime coordination for canonical navigation transitions and authoritative frontend acknowledgement updatesSection Commits
0bcc9d4bImplement canonical navigation phase 3 section 3.122e256b3Implement canonical navigation phase 3 section 3.2c319ff25Implement canonical navigation phase 3 section 3.37bcaeab5Implement canonical navigation phase 3 section 3.4Validation
cd packages/live_ui && mix test test/live_ui/examples_test.exs test/live_ui/runtime_navigation_test.exs test/live_ui/canonical_navigation_transport_integration_test.exs test/live_ui/canonical_navigation_web_runtime_integration_test.exscd packages/elm_ui && mix test test/elm_ui/examples_test.exs test/elm_ui/phase_six_integration_test.exs test/elm_ui/runtime_navigation_test.exs test/elm_ui/canonical_navigation_web_runtime_integration_test.exscd packages/elm_ui && mix elm_ui.validatemix spec.verify --debug-> unchanged repo baseline51 errors / 236 warningsmix spec.check-> unchanged repo baseline51 errors / 236 warningsmix spec.diffcheck-> unchanged single finding for unmappedAGENTS.mdKnown Baseline Issue
cd packages/live_ui && mix live_ui.validatestill fails on the existingJido.Signal.Ext.Registrystartup issue inLiveUi.Examples.MixedBoundaryTransport.compare_paths/0; this was already present and is unchanged by this PR.