Implement canonical navigation phase 4 non-web runtime mapping#147
Closed
pcharbon70 wants to merge 5 commits into
Closed
Implement canonical navigation phase 4 non-web runtime mapping#147pcharbon70 wants to merge 5 commits into
pcharbon70 wants to merge 5 commits into
Conversation
Collaborator
Author
|
Closing this draft because current main has removed the live_ui demo surface that this branch still modifies. If phase 04 work resumes, it should be rebased onto current main first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desktop_uicanonical navigation transitions with the existing screen registry, controller, history, and modal modelterminal_uicanonical navigation realization for screen replacement, bounded history, and capability-aware modal degradationSection Commits
5d6da541Implement canonical navigation phase 4 section 4.1d28df1c2Implement canonical navigation phase 4 section 4.27e76f715Implement canonical navigation phase 4 section 4.3c81b6d34Implement canonical navigation phase 4 section 4.4Validation
cd packages/desktop_ui && mix test test/desktop_ui/navigation/signal_test.exs test/desktop_ui/widgets/navigation_test.exs test/desktop_ui/navigation/integration_test.exs test/desktop_ui/transport_test.exs test/desktop_ui/canonical_navigation_transport_integration_test.exs test/desktop_ui/canonical_navigation_desktop_runtime_integration_test.exs test/desktop_ui/runtime_test.exscd packages/terminal_ui && mix test test/terminal_ui/runtime_test.exs test/terminal_ui/runtime_event_router_test.exs test/terminal_ui/transport_diagnostics_test.exs test/terminal_ui/transport_signal_test.exs test/terminal_ui/foundational_widget_families_test.exs test/terminal_ui/canonical_navigation_transport_integration_test.exs test/terminal_ui/canonical_navigation_terminal_runtime_integration_test.exscd packages/desktop_ui && mix test test/desktop_ui/examples_test.exscd packages/terminal_ui && mix test test/terminal_ui/examples_test.exs test/terminal_ui_test.exscd packages/desktop_ui && mix test test/desktop_ui/canonical_navigation_transport_integration_test.exs test/desktop_ui/canonical_navigation_desktop_runtime_integration_test.exs test/desktop_ui/canonical_navigation_non_web_examples_integration_test.exscd packages/terminal_ui && mix test test/terminal_ui/canonical_navigation_transport_integration_test.exs test/terminal_ui/canonical_navigation_terminal_runtime_integration_test.exs test/terminal_ui/canonical_navigation_non_web_examples_integration_test.exsmix spec.verify --debug-> unchanged repo baseline:51 errors / 236 warningsmix spec.check-> unchanged repo baseline:51 errors / 236 warningsmix spec.diffcheck-> unchanged single finding for unmappedAGENTS.mdNotes
desktop_uiwarnings about missingLiveUicompile-time modules are unchanged