feat: add stream field to UserInput for body-controlled SSE streaming#226
Open
hillhack wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
feat: add stream field to UserInput for body-controlled SSE streaming#226hillhack wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
hillhack wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: hillhack <2jyotihill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
response_model.pystream: bool = FalsetoUserInput.conversations.pyPOST /conversations/agent-retrieverendpoint. ReturnsStreamingResponsewhenstream=trueandChatResponsewhenstream=false. Setresponse_model=Noneto skip FastAPI schema inference for union responses. Kept/agent-retriever/streamas a backward-compatible alias.ui.pystreamin the request body. Useshttpxstreaming context manager (timeout=None) for SSE passthrough whenstream=true; falls back to standard buffered response otherwise.test_api_conversations_streaming.pyUserInput(...)calls to explicitly setstream=False. Added two tests inTestUnifiedEndpointStreamBranching: one verifiesstream=truereturnsStreamingResponse, the other verifiesstream=falsereturnsChatResponse.Usage
Non-Streaming (default behavior)