Skip to content

Add numeric elapsed_seconds to metrics JSON #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harsh-kumar-patwa wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −0
Open

Add numeric elapsed_seconds to metrics JSON #3943

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44e169e
Add numeric elapsed_seconds to metrics JSON
harsh-kumar-patwa Mar 2, 2026
ade94d0
Set total_elapsed_seconds to ERR on parse failure
harsh-kumar-patwa Mar 2, 2026
ae7ef79
Fix Python 3.8 compatibility: replace removesuffix with slice
harsh-kumar-patwa Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions flow/util/genMetrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ def extract_metrics(

failed = False
total = timedelta()
elapsed_seconds = {}
for key in metrics_dict:
if key.endswith("__runtime__total"):
# Big try block because Hour and microsecond is optional
Expand All @@ -341,10 +342,17 @@ def extract_metrics(
)
total += delta

stage = key[: -len("__runtime__total")]
elapsed_seconds[stage + "__elapsed_seconds"] = delta.total_seconds()

if failed:
metrics_dict["total_time"] = "ERR"
metrics_dict["total_elapsed_seconds"] = "ERR"
else:
metrics_dict["total_time"] = str(total)
metrics_dict["total_elapsed_seconds"] = total.total_seconds()

metrics_dict.update(elapsed_seconds)

metrics_dict = {
key.replace(":", "__"): value for key, value in metrics_dict.items()
Expand Down