Bump OR - fix createNewFlatNet flat/modnet name collision with BTerm#3959
Open
openroad-ci wants to merge 6 commits intoThe-OpenROAD-Project:masterfrom
Open
Conversation
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
designs/nangate45/tinyRocket/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -17.1 | -19.0 | Failing | | globalroute__timing__setup__tns | -30.0 | -35.3 | Failing | | finish__timing__setup__tns | -28.5 | -31.9 | Failing | designs/asap7/aes-block/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -3710.0 | -5150.0 | Failing | | globalroute__timing__setup__tns | -3650.0 | -4295.0 | Failing | | globalroute__timing__hold__ws | -22.5 | -25.9 | Failing | designs/nangate45/ariane133/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__tns | -583.0 | -642.0 | Failing | designs/nangate45/bp_fe_top/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | finish__timing__hold__ws | 0.0 | -0.002 | Failing | | finish__timing__hold__tns | 0.0 | -0.003 | Failing | designs/nangate45/bp_multi_top/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | finish__timing__setup__tns | -262.0 | -291.0 | Failing | designs/sky130hd/chameleon/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__antenna_diodes_count | 188 | 218 | Failing | designs/sky130hd/microwatt/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -300.0 | -352.0 | Failing | | detailedroute__antenna__violating__nets | 3 | 6 | Failing | Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
openroad-ci
force-pushed
the
secure-fix-insert-buffer-name-collision
branch
from
2243b0c to
db398b3
Compare
Update OR submodule to include the refactored collision detection logic in createNewFlatNet as recommended in code review. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
openroad-ci
force-pushed
the
secure-fix-insert-buffer-name-collision
branch
from
2f63cc1 to
5635871
Compare
Contributor
|
@maliberty How about this flow?
|
designs/rapidus2hp/cva6/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -0.138 | -0.101 | Tighten | | cts__timing__setup__tns | -287.0 | -205.0 | Tighten | | globalroute__timing__setup__tns | -575.0 | -584.0 | Failing | | finish__timing__setup__tns | -575.0 | -584.0 | Failing | designs/rapidus2hp/cva6/rules-verific.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -0.157 | -0.14 | Tighten | | cts__timing__setup__tns | -518.0 | -412.0 | Tighten | | globalroute__timing__setup__tns | -650.0 | -697.0 | Failing | | finish__timing__setup__tns | -650.0 | -697.0 | Failing | designs/rapidus2hp/hercules_is_int/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__ws | -0.105 | -0.104 | Tighten | | globalroute__timing__setup__tns | -907.0 | -1120.0 | Failing | | finish__timing__setup__ws | -0.105 | -0.104 | Tighten | | finish__timing__setup__tns | -907.0 | -1120.0 | Failing | Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createNewFlatNetflat net and modnet name collision with BTerm.assignstatements and multi-driver errors in VerilogWriter output that caused Kepler LEC failures in hierarchical designs (e.g.,bp_fe_top).OpenROAD PR
Root Cause
When
remove_buffersmerges two port-named nets (both having BTerms), it leaves:createNewFlatNet()now always names the new net after the BTerm and renames any colliding flat net or modnet first.🤖 Generated with Claude Code