Add systematic PRE/POST Tcl hooks for flow steps#3961
Draft
Dhirenderchoudhary wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Draft
Add systematic PRE/POST Tcl hooks for flow steps#3961Dhirenderchoudhary wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Dhirenderchoudhary wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
300713a to
d7ad043
Compare
maliberty
requested changes
Mar 6, 2026
Member
There was a problem hiding this comment.
Don't remove the blank lines that serve as visual separation
Author
There was a problem hiding this comment.
i'll fix that sorry. for the inconvience.
flow/scripts/variables.yaml
Outdated
Comment on lines
+295
to
+280
| optimal distribution of registers on long pipelines. See OR discussion #8080. | ||
| optimal distribution of registers on long pipelines. See OR discussion # 8080. |
Member
There was a problem hiding this comment.
Wrong to add a space here as this is an issue reference.
flow/scripts/variables.yaml
Outdated
Comment on lines
+751
to
+738
| Do not perform VT swap on critical cells to improve QoR (default: do critical VT swap). | ||
| This is an additional VT swap on critical cells that remain near the end of setup fixing. | ||
| Do not perform VT swap on critical cells to improve QoR (default: do critical | ||
| VT swap). | ||
| This is an additional VT swap on critical cells that remain near the end of setup | ||
| fixing. |
Comment on lines
+3
to
5
| source_step_tcl PRE GLOBAL_PLACE | ||
| erase_non_stage_variables place | ||
| load_design 3_2_place_iop.odb 2_floorplan.sdc |
Member
There was a problem hiding this comment.
The pre hook should be after the design is loaded otherwise it is very limited in what it can do. The is the same in all files.
Signed-off-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmail.com>
d7ad043 to
c8b1170
Compare
Signed-off-by: Dhirender Choudhary <dhirenderchoudhary0001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date : 6 March 2026
Developer name : @Dhirenderchoudhary
Description
Implement systematic PRE/POST Tcl step hooks across ORFS so users can inject custom Tcl before and after each major flow step without editing core scripts.
This adds:
Generic hook resolver helper in flow/scripts/util.tcl
PRE_TCL and POST_TCL sourcing in flow step scripts (synth/floorplan/place/cts/route/final)
Variable metadata entries in flow/scripts/variables.yaml
Regenerated hook documentation in docs/user/FlowVariables.md
Related Issue
Closes #3177
Type of Change
Testing
Checklist