Use swig from BCR, allowing to remove last dep on WORKSPACE#9555
Conversation
|
CC: @oharboe |
There was a problem hiding this comment.
Code Review
This pull request migrates the swig dependency from a WORKSPACE definition to using the version from the Bazel Central Registry (BCR). This is a great improvement for modernizing the build and removing the legacy WORKSPACE file. The changes in the .bzl files to update the swig label are correct. I've only left one comment in MODULE.bazel regarding the alphabetical sorting of dependencies to improve maintainability.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
😌 |
|
It is unclear why the CI failed - there are no usable logs. |
|
making this a draft for now. Looks like the other CI shows an actual error that can be traced to swig |
|
[2026-02-26T17:18:41.705Z] (17:18:41) ERROR: /tmp/workspace/OpenROAD-Public_PR-9555-head-1-bazel-ci/src/ant/BUILD:75:12: Action src/ant/swig.cc [for tool] failed: (Exit 1): swig failed: error executing Action command (from target //src/ant:swig) bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/swig+/swig -tcl8 -c++ -module ant -namespace -prefix ant -Isrc/ant/src -o bazel-out/k8-opt-exec-ST-d57f47055a04/bin/src/ant/swig.cc ... (remaining 1 argument skipped) |
|
Looks like the BCR version is doing things a bit differently. Will have to dig into that and possibly upstream a fix. |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
82ccb13 to
18634e4
Compare
Signed-off-by: Henner Zeller <h.zeller@acm.org>
18634e4 to
b02bdbf
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Added swig Note, even though we could remove |
|
Ready for review. |
No description provided.