Skip to content

Fix: replace_arith_modules ignores -slack_threshold due to key mismatch #9580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 6 commits into from
Mar 2, 2026
+9 −8
Merged

Fix: replace_arith_modules ignores -slack_threshold due to key mismatch #9580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d5c7b2
rsz: fix replace_arith_modules ignoring -slack_threshold
suhr25 Mar 1, 2026
dc06201
fix: align slack_threshold naming and logging in replace_arith_modules
suhr25 Mar 2, 2026
265eca9
style: fix Tclint line-length for replace_arith_modules log
suhr25 Mar 2, 2026
07b8e32
test: update replace_arith_modules expected logs for slack_threshold
suhr25 Mar 2, 2026
99739bf
test: update replace_arith_modules expected logs for slack_threshold
suhr25 Mar 2, 2026
62fd8dd
chore: remove accidental file
suhr25 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/rsz/src/Resizer.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,14 +760,15 @@ proc replace_arith_modules { args } {
} else {
set target "setup"
}
if { [info exists keys(-slack_margin)] } {
set slack_margin [rsz::parse_time_margin_arg "-slack_margin" keys]
if { [info exists keys(-slack_threshold)] } {
set slack_threshold [rsz::parse_time_margin_arg "-slack_threshold" keys]
} else {
set slack_margin 0.0
set slack_threshold 0.0
}

puts "replace_arith_module -path_count $path_count -target $target -slack_margin $slack_margin"
rsz::swap_arith_modules_cmd $path_count $target $slack_margin
puts [format "replace_arith_modules -path_count %s -target %s -slack_threshold %s" \
$path_count $target $slack_threshold]
rsz::swap_arith_modules_cmd $path_count $target $slack_threshold
}

sta::define_cmd_args "report_buffers" { [-filtered] }
Expand Down
2 changes: 1 addition & 1 deletion src/rsz/test/replace_arith_modules1.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
number instances in verilog is 39260
wns max -85.02
tns max -174582.05
replace_arith_module -path_count 100 -target setup -slack_margin 0.0
replace_arith_modules -path_count 100 -target setup -slack_threshold 0.0
[INFO RSZ-0151] Starting arithmetic module replacement to optimize 'setup' target
[INFO RSZ-0152] Analyzing 100 critical paths with slack < 0.00
[INFO RSZ-0153] Identified 3788 violating endpoints
Expand Down
2 changes: 1 addition & 1 deletion src/rsz/test/replace_arith_modules2.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
number instances in verilog is 39324
wns max -85.02
tns max -174555.69
replace_arith_module -path_count 100 -target setup -slack_margin 0.0
replace_arith_modules -path_count 100 -target setup -slack_threshold 0.0
[INFO RSZ-0151] Starting arithmetic module replacement to optimize 'setup' target
[INFO RSZ-0152] Analyzing 100 critical paths with slack < 0.00
[INFO RSZ-0153] Identified 3787 violating endpoints
Expand Down
2 changes: 1 addition & 1 deletion src/rsz/test/replace_arith_modules3.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Using 2 tracks default min distance between IO pins.
number instances in verilog is 39260
wns max -85.02
tns max -174582.05
replace_arith_module -path_count 100 -target setup -slack_margin 0.0
replace_arith_modules -path_count 100 -target setup -slack_threshold 0.0
[INFO RSZ-0151] Starting arithmetic module replacement to optimize 'setup' target
[INFO RSZ-0152] Analyzing 100 critical paths with slack < 0.00
[INFO RSZ-0153] Identified 3788 violating endpoints
Expand Down