Skip to content

ui swig uses :IpChecker: add that dependency.#9599

Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20260302-add-missing-ipchecker
Mar 2, 2026
Merged

ui swig uses :IpChecker: add that dependency.#9599
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20260302-add-missing-ipchecker

Conversation

@hzeller
Copy link
Collaborator

@hzeller hzeller commented Mar 2, 2026

No description provided.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the :IpChecker dependency to the ui cc_library in src/dbSta/BUILD. This change is correct as the ui library uses symbols from IpChecker via its SWIG interface, and this dependency was missing.

@hzeller hzeller force-pushed the feature-20260302-add-missing-ipchecker branch from c6c6495 to af0be26 Compare March 2, 2026 22:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty enabled auto-merge March 2, 2026 23:07
@maliberty maliberty merged commit 7683add into The-OpenROAD-Project:master Mar 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants