Fix duplicate Practice #35 numbering in CodingPractices.md#9670
Conversation
…ctices.md Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adjusts the numbering for several practices in CodingPractices.md to resolve a duplicate and also fixes a typo. The changes are appropriate. I have included one suggestion to improve the clarity of a code example that is related to the modified content.
Note: Security Review has been skipped due to the limited scope of the PR.
| ### Practice #38 | ||
|
|
||
| Don't use `glob`. Explictly list the files in a group. | ||
| Don't use `glob`. Explicitly list the files in a group. |
There was a problem hiding this comment.
The code example that follows this practice is a bit confusing. It shows list(REMOVE_ITEM ...) which doesn't clearly illustrate the alternative to using glob. To improve clarity, consider changing the example to show how to explicitly list files, for instance, by using set(SRC_FILES ...) with an explicit list of files.
|
clang-tidy review says "All clean, LGTM! 👍" |
2 participants
No description provided.