Open
Conversation
cjdutoit
reviewed
Jan 27, 2025
| [YamlMember(Alias = "pull_request", DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | ||
| public PullRequestEvent PullRequest { get; set; } | ||
|
|
||
| public ScheduledEvent[] Schedule { get; set; } |
Collaborator
There was a problem hiding this comment.
Suggested change
| public ScheduledEvent[] Schedule { get; set; } | |
| [YamlMember(DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
| public ScheduledEvent[] Schedule { get; set; } |
cjdutoit
reviewed
Jan 27, 2025
|
|
||
| namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets | ||
| { | ||
| public class EventsV2 |
Collaborator
There was a problem hiding this comment.
Add documentation everywhere
cjdutoit
reviewed
Jan 27, 2025
|
|
||
| namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets | ||
| { | ||
| public class ScheduledEvent |
Collaborator
There was a problem hiding this comment.
Add documentation everywhere
cjdutoit
reviewed
Jan 27, 2025
|
|
||
| public ScheduledEvent[] Schedule { get; set; } | ||
|
|
||
| [YamlMember(Alias = "workflow_dispatch")] |
Collaborator
There was a problem hiding this comment.
Suggested change
| [YamlMember(Alias = "workflow_dispatch")] | |
| [YamlMember(Alias = "workflow_dispatch", DefaultValuesHandling = DefaultValuesHandling.OmitDefaults))] |
cjdutoit
reviewed
Jan 27, 2025
Collaborator
cjdutoit
left a comment
cjdutoit
left a comment
There was a problem hiding this comment.
Remove components already on other PR's
cjdutoit
reviewed
Jan 27, 2025
Comment on lines
+13
to
+14
| [YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | ||
| public string Cron { get; set; } |
Collaborator
There was a problem hiding this comment.
Suggested change
| [YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
| public string Cron { get; set; } | |
| [YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
| public string Cron { get; set; } | |
| [YamlMember(Order = 1, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
| public string Interval { get; set; } |
cjdutoit
reviewed
Jan 27, 2025
| namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets | ||
| { | ||
| public class WorkflowDispatchEvent | ||
| { } |
Collaborator
There was a problem hiding this comment.
This seems incomplete, I was expecting properties
Suggested change
| { } | |
| { | |
| [YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
| public WorkflowDispatchInput Environment { get; set; } | |
| [YamlMember(Order = 1, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
| public WorkflowDispatchInput Version { get; set; } | |
| [YamlMember(Order = 2, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
| public WorkflowDispatchInput DryRun { get; set; } | |
| } |
with
public class WorkflowDispatchInput
{
[YamlMember(Order = 0]
public string Description { get; set; }
[YamlMember(Order = 1]
public bool Required { get; set; }
[YamlMember(Order = 2]
public string Default { get; set; }
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #143