Changed tooltip from center to left justified (from main visualisatio…

[Lextuga007]

…n page)

[Lextuga007]

Followed code change in #228 where tooltips in sidebar set to left justified.

[matt-dray]

Cheers, thanks for spotting this and taking the initiative to make the correction.

I'm not sure why entire files are showing as changed, rather than the pertinent lines. It's not the biggest deal in the world, but will make the version history and blame trickier to understand in future.

Maybe line endings? To check: have you got your IDE and Git config set up to use LF endings? I just re-checked mine and I do.

Marking as 'request changes' while you investigate.

[matt-dray]

Tests are still not properly fixed in this repo (#221), so don't worry about the failing tests in the PR action.

I have been re-running the snapshot tests for PRs where I've updated the UI, though. You can do that by running the test suite (Ctrl+Shift+T in RStudio I think) and then testthat::snapshot_accept() if the snapshots have changed.

[Lextuga007]

I'm puzzled by the large diffs too as my settings match the guide with only Reformat documents on save:

I had this previously with scenario comparator and it was possibly because those scripts hadn't been changed for a while and retained differences. I can split out the changes so do a save of the files, prompted by a space or return, so that can be ignored as a specific commit.

[Lextuga007]

I've split out the commits so that the full script reformatting (which still appears in the PR) is ignored through .git-blame-ignore-revs and the next commit just shows the changes to code for left adjustment. I've updated this PR rather than start again to retain the discussion.

[matt-dray]

Couple of other things to check before merging, in case we can solve it:

1. Do you get false if you run git config get core.autocrlf in the terminal?
2. What does air --version produce? I just realised I'm on an older version.

[matt-dray]

Incidentally, we know it's a whitespace issue because you can remove whitespace from the diff in the layout menu (the cog icon):

[Lextuga007]

I get false running the git code and air is version 0.9.0 which is a bit out of date now - I hadn't realised. I also didn't know about the hide whitespace in review. That's useful thanks.

[matt-dray]

Okey-dokey, cheers. I'll deal separately with a whole-repo line-endings clean-up and will do #233 to help us out as well.