Add is_palindrome_ignore_case_and_spaces to strings/palindrome.py#14907
Add is_palindrome_ignore_case_and_spaces to strings/palindrome.py#14907kaviya-ns wants to merge 1 commit into
Conversation
Abhirai2006
left a comment
There was a problem hiding this comment.
Nice small addition, thanks! Two things I noticed though:
The doctest with "Was it a car or a cat I saw?" returns False, but that's kind of an accident — it's only False because the trailing "?" doesn't get stripped (the function only removes spaces, not punctuation). If you actually remove the "?", that phrase is a real palindrome ignoring case/spaces. So the test passes but not really for the reason you'd want it to. Might be worth swapping in a cleaner example, or handling punctuation too so the function does what its name says.
Also the new assert in main (is_palindrome(key) == is_palindrome_ignore_case_and_spaces(key)) is checked against the existing test_data, but none of those strings have spaces or mixed case — so it's not really testing the new behavior, just repeating the old check. Adding one or two mixed-case/spaced entries would make that assertion actually mean something.
Otherwise looks good, happy to approve once these are sorted.
Describe your change:
Adds a new function
is_palindrome_ignore_case_and_spacestostrings/palindrome.pythat checks whether a string is a palindrome while ignoring letter case and spaces.
Existing functions in the file are unchanged.
Checklist: