Cross-platform support, completely refactor the project.#18
Cross-platform support, completely refactor the project.#18PurelyAndy wants to merge 25 commits into
Conversation
Co-Authored-By: VashBaldeus <vashbaldeus@gmail.com>
Co-Authored-By: stevebroskey <946790+stevebroskey@users.noreply.github.com>
anyway, reading and writing are done.
|
I don't own a PS5, so I can't test the UART communication code. If anybody is willing to help me out with that, please let me know. |
|
Don’t have an open ps5 to test on but lmk if you would like any help |
|
Hey @PurelyAndy, I've taken a brief look at the refactored code and agree that this is the direction we should be heading in. This fork is very well organized and solves many problems the current main branch has. I'm attempting to merge a small change I made but I don't have write access to your fork. Would you be able to provide that for me? Thanks :3 |
|
This is good. We still need to clean up https://github.com/PurelyAndy/PS5NorModifier/blob/main/UART-CL_By_TheCod3r/Program.cs 's monolithic class |
|
Yeah, I'm working on that right now. There's a lot of shared code between the GUI and CLI apps that needs to be consolidated. |
|
@benjamin238 I'll give you access now. It's in your email. |
PurelyAndy
changed the title
|
Why downgrade from .NET 9 to .NET 8 out of curiosity? Could it not be compiled as Native AOT? Avalonia supports it: https://docs.avaloniaui.net/docs/deployment/native-aot |
|
.NET 8 is LTS. I don't know how often they want to update the .NET version of this project. It's trivial to update it back to .NET 9 or 10 in the future, anyway. |
Internally document model codes, rename some variables with unclear names, resolved dependency problems (wouldn't compile without this)
|
I've also submitted a PR for a rewrite and to clean up the CLI, but I took a more drastic approach. @PurelyAndy if you want to take a look #33 |
6 participants
I'm rewriting the GUI with Avalonia and restructuring the projects, moving shared code, cleaning up, etc.