This repository was archived by the owner on Sep 26, 2022. It is now read-only.
fix(Tooltip.svelte): don't destroy tip node, let svelte do it#268
Open
dablach wants to merge 1 commit intoTheComputerM:masterfrom
Open
fix(Tooltip.svelte): don't destroy tip node, let svelte do it#268dablach wants to merge 1 commit intoTheComputerM:masterfrom
dablach wants to merge 1 commit intoTheComputerM:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/9ZrQCqm2zkK8cqrCRFyZaDxaRASh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When destroying a Tooltip, the tooltip node was removed twice: once by svelte and once by the component.
This pull requests removes the
removeChildcall in the component and adds a test, that checks if the Tooltip component can be destroyed without an error and the tooltip node gets removed correctly.