fix loading crash caused by broken plugins#1224
Merged
AdvancedImagingUTSW merged 3 commits intoMay 28, 2026
Merged
Conversation
Broaden file-based plugin module loading to catch ImportError, which covers Windows DLL/CuPy import failures as well as missing modules. The helper now also handles missing import specs or loaders by returning None instead of crashing during startup. Keep plugin managers type-hinted and documented in numpydoc style, and normalize importlib resource paths before passing them to APIs that expect filesystem strings. Add regression coverage for configured file plugins whose controller import fails, plus helper-level tests for ImportError and missing spec/loader cases.
AdvancedImagingUTSW
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.