Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
romainljsimon
approved these changes
Feb 2, 2026
Member
romainljsimon
left a comment
romainljsimon
left a comment
There was a problem hiding this comment.
Didn't check thoroughly #65 yet, but that's good for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the validation subdirectory and moves its content to example.
I initially felt like a validation subdir had some sense, as it shows that the code actually does what it should.
With #65 that adds a thorough example, I feel like it makes more sense to put everything as examples.
Maybe at some point add a README to explain that the results were validated, with a link to the LJ mixture example?