Open
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Member
|
T'es le meilleur |
V-Francois
reviewed
Feb 13, 2026
Contributor
V-Francois
left a comment
V-Francois
left a comment
There was a problem hiding this comment.
Sorry I'm late to the party.
Great PR!
I just have a comment on the energy callback.
| function callback_chain_correlation(simulation) | ||
| return mean(compute_chain_correlation(system) for system in simulation.chains) | ||
| Arianna.@callback function energy(system::Particles) | ||
| return system.energy[1] |
Contributor
There was a problem hiding this comment.
Is this the total energy, or the energy per particle? The previous callback was per particle.
Ideally, there should be a comment to say explicitly which one it is.
Contributor
There was a problem hiding this comment.
I just ran a test, and it looks like now the energy is the total energy, instead of the energy/particles.
Is this intended?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files are changed to comply with the new
Ariannaversion.Now, each
chainhas its own numbered folder, where individual callbacks+ trajectories are stored.The acceptance is not a callback anymore and the
StoreAcceptancealgorithm is now used. TheStoreAcceptancealgorithm is now parsed, when running commands from CLI.Callbacks have changed names and are not named
function callback_*.Callback functions are not written as: