Fix doc/comment accuracy and dead code in grab template execution#627
Merged
TheJoeFin merged 2 commits intograb-templatesfrom Mar 5, 2026
Merged
Fix doc/comment accuracy and dead code in grab template execution#627TheJoeFin merged 2 commits intograb-templatesfrom
TheJoeFin merged 2 commits intograb-templatesfrom
Conversation
…ables Co-authored-by: TheJoeFin <7809853+TheJoeFin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix overlapping buttons in Post Grab Actions window
Fix doc/comment accuracy and dead code in grab template execution
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four inaccuracies flagged in code review of the grab templates feature:
ValidateOutputTemplateused{{{{num}}}}which renders as the literal{{num}}instead of the actual missing placeholder number. Fixed to{{{num}}}so the message shows e.g.{3}.ExecuteTemplateAsync—captureRegionwas documented as "WPF units", butOcrUtilities.GetTextFromAbsoluteRectAsynctreats it as physical screen pixels. Updated accordingly.UpdateTemplateRegionOverlays— claimed "UniformToFill semantics" but the implementation scales each axis independently (stretch-to-fill). Comment updated to match reality.scaleXandscaleYwere computed but never referenced inUpdateTemplateRegionOverlays.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.