Fix five review issues: shortcut hints, ItemsDictionary duplicates, null ItemsSource, duplicate chip handlers, Freeform key hint#629
Merged
TheJoeFin merged 2 commits intograb-templatesfrom Mar 7, 2026
Conversation
…sSource, duplicate handlers, Freeform key hint Co-authored-by: TheJoeFin <7809853+TheJoeFin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix overlapping buttons in Post Grab Actions window
Fix five review issues: shortcut hints, ItemsDictionary duplicates, null ItemsSource, duplicate chip handlers, Freeform key hint
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five correctness issues flagged in code review of the grab-templates PR, covering misleading UI hints, data duplication, and defensive null/event-handler handling.
Changes
FullscreenGrab.xaml.cs–AddPostGrabActionMenuItem: CapInputGestureTexttoCtrl+1–Ctrl+9; omit for indices > 9 since no keyboard handler exists beyondKey.D9.QuickSimpleLookup.xaml.cs–LoadDataGridContent: AddItemsDictionary.Clear()beforeAddRange; without it, re-invoking the method (e.g. via "Import from CSV") duplicates all rows, history, and templates.InlinePickerRichTextBox.cs–ItemsSourcegetter: Guard against the DP returningnullbefore the property is ever set — previously threwNullReferenceException.InlineChipElement.cs–OnApplyTemplate: StorePART_RemoveButtonin a field and detach the previousClickhandler before re-attaching via a named method. Lambda-per-call caused multipleRemoveRequestedfires on a single click after theme/template switches.FullscreenGrab.xaml– Freeform menu item: CorrectInputGestureTextfrom"P"to"D"to matchGetSelectionStyleKeyreturningKey.DforFsgSelectionStyle.Freeform.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.