Fix bitmap disposal leaks and isDrawing stuck state from PR review#631
Merged
TheJoeFin merged 3 commits intoui-automationfrom Mar 8, 2026
Merged
Fix bitmap disposal leaks and isDrawing stuck state from PR review#631TheJoeFin merged 3 commits intoui-automationfrom
TheJoeFin merged 3 commits intoui-automationfrom
Conversation
…ents Co-authored-by: TheJoeFin <7809853+TheJoeFin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add UI automation to grab direct text from UI elements
Fix bitmap disposal leaks and isDrawing stuck state from PR review
Mar 8, 2026
Disposing selectionBitmap with a using statement caused app crashes. Now, the bitmap is not disposed immediately, and a comment was added to highlight the issue and the need for further investigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses four issues flagged in the PR review for the UI Automation / Direct Text feature.
Changes
Bitmap bmpinGetRegionsTextAsTableAsyncandGetOcrResultFromRegionAsyncwas never disposed. Addedusingdeclarations to ensure disposal on all code paths (WindowsAI early-return and standard OCR path).isDrawingstuck after null OCR result —DrawOcrRectanglesAsyncreturned early whenocrResultOfWindowwas null without resettingisDrawing = falseor restartingreDrawTimer, permanently blocking future redraws. Now matches the same reset pattern used for the invalid canvas-size early return above it.ClearRenderedWordBorders()misleading indentation — The call was indented as if inside the bracelessif (!hasLoadedImageSource)block but always executed unconditionally. Fixed indentation to reflect actual control flow.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.