Draft
Conversation
… eiken-thieving
…eiken-thieving
… eiken-thieving
… eiken-thieving
… eiken-thieving
advnau
reviewed
Dec 21, 2025
| val cache = Cache.load(File(getCacheLocation()).toPath()) | ||
|
|
||
| GamevalDumper.dumpCols(cache,rev.first) | ||
| GamevalDumper.dumpCols(cache, rev.first) |
There was a problem hiding this comment.
please keep any formatting changes to a minimum. We have a bunch of formatting/whitespace changes in this file and then 1 substantial adding the pickpocket. Optimally i prefer any formatting changes to be isolated prs with no new/changed code.
| val highChance: Int | ||
| ) | ||
|
|
||
| val definitions: List<PickpocketNPCData> = table("tables.skill_thieving_pickpocketing").map { row -> |
There was a problem hiding this comment.
since you made the table in dbtables, after generating it will autogenerate this glue for you under the content/generated/org/alter
|
|
||
| allNpcs.forEach { (_, npcDef) -> | ||
| if (!npcDef.actions.contains("Pickpocket")) return@forEach | ||
| if (npcDef.category != -1) { |
There was a problem hiding this comment.
maybe introduce 2 functions here, this code is fairly nested and with the else statement before that would add clarity.
|
|
||
|
|
||
| private fun canPickpocket(player: Player, npc: Npc, data: Pickpocketing.PickpocketNPCData): String? { | ||
| if (player.getSkills().getCurrentLevel(Skills.THIEVING) < data.level) { |
|
@codex review |
…nto eiken-thieving
…nto eiken-thieving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.