-
Notifications
You must be signed in to change notification settings - Fork 151
docs: Fix spelling errors in Core, GameEngineDevice, Libraries, and Tools comments #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: Fix spelling errors in Core, GameEngineDevice, Libraries, and Tools comments #2147
Conversation
Greptile Overview
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/Common/AudioEventRTS.h | Fixed spelling errors in comments: 'specifc' → 'specific', 'overrided' → 'overridden', completed incomplete comment |
| Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/Shadow/W3DVolumetricShadow.cpp | Fixed spelling errors: 'efficienty' → 'efficiently', 'onces' → 'ones', 'columes' → 'columns' |
| Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DAssetManager.cpp | Fixed spelling: 'exisiting' → 'existing' in two locations |
| Generals/Code/Libraries/Source/WWVegas/WW3D2/meshmdlio.cpp | Fixed spelling: 'coordiantes' → 'coordinates', 'coordiante' → 'coordinate' |
| Generals/Code/Tools/GUIEdit/Source/GUIEdit.cpp | Fixed spelling errors: 'cofig' → 'config', 'componenets' → 'components', 'beyong' → 'beyond' |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Files as Source Files
participant Comments as Code Comments
participant PR as Pull Request
Dev->>Files: Identify spelling errors in comments
Files->>Comments: Read existing comments
Comments-->>Dev: Return misspelled words
Dev->>Comments: Fix spelling errors
Note over Comments: specifc → specific<br/>overrided → overridden<br/>implemenation → implementation<br/>exisiting → existing<br/>etc.
Dev->>Files: Update comments in 66 files
Files-->>PR: Submit changes
Note over PR: Only comment changes<br/>No logic modifications<br/>Consistent across all files
Generals/Code/GameEngine/Include/GameLogic/Module/ProductionUpdate.h
Outdated
Show resolved
Hide resolved
52e144d to
9a95d76
Compare
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daily dose of Bobtista changes
|
I do not understand the splitting of this change. The title claims one thing, but the actual changes files are in all sorts of unrelated folders that do correspond to what the title says. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
120 files reviewed, 2 comments
I think it's because there were multiple commits, and main has changed, I bet if I rebase and squash it's clean |
009d817 to
e5ef95a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Pull contains edits to Generals/Core/GameEngine/Include
Wouldn't that fit better into #2145, which also touched this portion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I moved those changes there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this Pull touch code in Generals, when there is no other Pull that touches equivalent files for Zero Hour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the fixes I could find here to this PR, it's still less than 100 files touched
b68e07b to
7141d5b
Compare
Fix spelling errors in code comments.
Covers: