Skip to content

bugfix: GLA Battle Bus can now respond to attack commands while in bunkered form #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stubbjax wants to merge 5 commits into
base: main
Choose a base branch
from
Open

bugfix: GLA Battle Bus can now respond to attack commands while in bunkered form #2213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eecc56d
bugfix: Bunkered Battle Buses can now respond to attack commands
Stubbjax Aug 3, 2025
1407809
bugfix: Prevent building on bunkered Battle Buses
Stubbjax Aug 3, 2025
33a5ab8
bugfix: Disable attack-move and guard commands for bunkered Battle Bu…
Stubbjax Aug 3, 2025
66d1f2b
docs: Add comments
Stubbjax Jan 27, 2026
58d4b58
refactor: Implement cleaner solution
Stubbjax Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Generals/Code/GameEngine/Source/GameLogic/AI/AIGroup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2112,10 +2112,14 @@ void AIGroup::groupAttackObjectPrivate( Bool forced, Object *victim, Int maxShot
for( i = m_memberList.begin(); i != m_memberList.end(); ++i ) {
Real dx, dy;
Coord3D unitPos = *((*i)->getPosition());
#if RETAIL_COMPATIBLE_CRC
// TheSuperHackers @bugfix Stubbjax 03/08/2025 This logic block erroneously prevents the
// occupants of DISABLED_HELD units (e.g. undead Battle Buses) from responding to attack commands.
if ((*i)->isDisabledByType( DISABLED_HELD ) )
{
continue; // don't bother telling the occupants to move.
}
#endif
dx = unitPos.x - victimPos.x;
dy = unitPos.y - victimPos.y;
iter->insert((*i), dx*dx+dy*dy);
Expand Down
4 changes: 4 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIGroup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2175,10 +2175,14 @@ void AIGroup::groupAttackObjectPrivate( Bool forced, Object *victim, Int maxShot
for( i = m_memberList.begin(); i != m_memberList.end(); ++i ) {
Real dx, dy;
Coord3D unitPos = *((*i)->getPosition());
#if RETAIL_COMPATIBLE_CRC
// TheSuperHackers @bugfix Stubbjax 03/08/2025 This logic block erroneously prevents the
// occupants of DISABLED_HELD units (e.g. undead Battle Buses) from responding to attack commands.
if ((*i)->isDisabledByType( DISABLED_HELD ) )
{
continue; // don't bother telling the occupants to move.
}
#endif
dx = unitPos.x - victimPos.x;
dy = unitPos.y - victimPos.y;
iter->insert((*i), dx*dx+dy*dy);
Expand Down
Loading