bugfix: China Emperor Overlord now benefits from the Subliminal Messaging upgrade#137
Open
Stubbjax wants to merge 1 commit into
Open
bugfix: China Emperor Overlord now benefits from the Subliminal Messaging upgrade#137Stubbjax wants to merge 1 commit into
Stubbjax wants to merge 1 commit into
Conversation
Stubbjax
added
Bug
|
Is not linked to TheSuperHackers/GeneralsGamePatch#236 in Migration Project |
|
Is missing Rationale text. |
xezon
reviewed
Jul 10, 2026
xezon
added
Design
xezon
approved these changes
Jul 12, 2026
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Code looking correct. Would have been good if rationale text was highlighted as such.
| UpgradeCameo2 = Upgrade_ChinaNuclearTanks | ||
| UpgradeCameo3 = Upgrade_ChinaOverlordGattlingCannon | ||
| UpgradeCameo4 = Upgrade_ChinaOverlordPropagandaTower | ||
| UpgradeCameo5 = Upgrade_ChinaSubliminalMessaging |
There was a problem hiding this comment.
The other Overlords do not have this cameo, maybe because there is not enough room for it. Is that ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change allows the China Emperor Overlord to benefit from the Subliminal Messaging upgrade. This doubles the healing rate and provides an additional +25% rate of fire for those under its influence.
This change also adds the Subliminal Messaging upgrade icon to the unit and the Propaganda Tower upgrade icon is no longer greyed out, as the upgrade is intrinsic.
Details
All Propaganda Towers now benefit from the Subliminal Messaging upgrade. This in turn makes the Emperor Overlord and surrounding allied forces stronger. The Emperor Overlord is an identical copy of the standard Overlord, apart from its initial veteran promotion, built-in Propaganda Tower, and ability to upgrade a Gattling Cannon on top of it.
The Emperor Overlord would have been intended to get the Subliminal Messaging upgrade, but
Upgrade_ChinaSubliminalMessagingwas likely confused withUpgrade_ChinaOverlordPropagandaTowerwhen assigning the required upgrade to thePropagandaTowerBehaviormodule'sUpgradeRequiredfield.Rationale
In 1.04, the China Overlord can actually win in a head to head against the Emperor Overlord if they have the same veterancy level. This is counterintuitive, because the Tank General is expected to have the superior arsenal of tanks, while having disadvantages in other areas.
A game's rules and mechanics should also be applied consistently. In this case, the Subliminal Messaging upgrade's contract - that all Propaganda sources are boosted - was not universally applied. Every exception to a rule adds an additional layer of complexity and cognitive load to players, so exceptions should be carefully considered and controlled, and have a very solid foundation and reason for existing. An arbitrary malfunction such as this one has no good reason to exist.
After this change, an Emperor Overlord will no longer perform worse against the other Overlord variants with the Subliminal Messaging upgrade, which is more in-line with player expectations.
Testing
Before
A standard Overlord with Subliminal Messaging wins against an Emperor Overlord of the same level in a head to head
BEFORE.mp4
After
A standard Overlord and an Emperor Overlord of the same level draw in a head to head
AFTER.mp4