bugfix: GLA Stealth Saboteur can now sabotage Internet Centers and fake buildings like its vanilla GLA counterpart

[Stubbjax]

Summary

This change allows the GLA Stealth Saboteur to sabotage Internet Centers and fake buildings like its vanilla GLA counterpart.

Note

This change also applies to the Demo Saboteur, which is unavailable by default.

Details

Sabotaging an Internet Center will disable it (and any Hackers inside) for 15 seconds. Sabotaging a fake building will destroy it.

These behaviours are explicitly coded modules, SabotageInternetCenterCrateCollide and SabotageFakeBuildingCrateCollide, indicating that this was intended behaviour that mistakenly never made it across to the faction variants.

Behavioural differences in 1.04:

Building	vGLA Saboteur	GLA Stealth Saboteur
Command Center	✔️	✔️
Fake Building	✔️
Internet Center	✔️
Military Factory	✔️	✔️
Supply Center	✔️	✔️

Important

Vanilla GLA Saboteurs can distinguish fake Black Markets from real ones in 1.04. Conversely, Stealth Saboteurs can distinguish all fake buildings except for Black Markets. This behaviour is visualised below.

A vGLA Saboteur can sabotage the following in 1.04:

Building	Fake	Real
Arms Dealer	✔️	✔️
Barracks	✔️	✔️
Black Market	✔️
Command Center	✔️	✔️
Supply Stash	✔️	✔️

A GLA Stealth Saboteur can sabotage the following in 1.04:

Building	Fake	Real
Arms Dealer		✔️
Barracks		✔️
Black Market
Command Center		✔️
Supply Stash		✔️

As a result of this change, all Saboteur behaviour now matches the vGLA behaviour, in which the only distinguishable fake/real buildings are Black Markets. This is expected to be fixed in a future change by allowing all Saboteurs to sabotage Black Markets and Supply Drop Zones.

Rationale

This change gives the seldom-used Saboteur some additional utility and is a step towards reducing the severity of the fake vs real building exploit in which they can be told apart via the mouse cursor while a Saboteur is selected.

It is important that unit variants between factions do not have undisclosed and seemingly arbitrary differences, as they otherwise make the game state harder to read and outcomes harder to predict.

[xezon]

Migration Project does not link this to TheSuperHackers/GeneralsGamePatch#544

[xezon]

Since the Stealth General's Saboteur could not originally sabotage fake buildings, the cursor that appears when hovering above an enemy GLA Barracks, Arms Dealer, Supply Stash or Command Center could be used to distinguish real and fake buildings.

Note: This does however enable the Stealth Saboteur to distinguish real and fake Black Markets via the cursor like the vanilla GLA Saboteur can. This is expected to be fixed in a future change by allowing Saboteurs to sabotage Black Markets and Supply Drop Zones.

I am confused by these 2 sentences. They appear to contradict each other.

[xezon]

Rationale text is missing.

[xezon]

Fix for Demo Saboteur is missing.

[Stubbjax]

I am confused by these 2 sentences. They appear to contradict each other.

I've made it a bit clearer.

Fix for Demo Saboteur is missing.

Updated.

[xezon]

Code looks correct. INI doc would have been nice.