bugfix: Destroyed GLA Demo units with the Demolitions upgrade now detonate nearby explosive units

[Stubbjax]

Summary

This change causes GLA units with the Demolitions upgrade to detonate nearby explosive units upon death.

Details

When a GLA Demo unit dies after having researched the Demolitions upgrade, it lightly explodes and deals 50 damage to nearby enemies. This is shown in the video below.

DEMO.mp4

As of this change, if an enemy unit dies to this damage, it is now considered an EXPLODED death, and triggers any explosive death behaviours for the killed unit (e.g. Terrorists will detonate themselves).

The primary impact of this change is that if an enemy Terrorist or Demo Bike is nearby and dies to this damage, they too will explode and potentially cause collateral damage in the process.

Rationale

This change is an effort towards consistent behaviour to streamline design language and mechanics.

Explosive units, such as Terrorists, generally explode via certain death types. These usually include SUICIDED, CRUSHED, SPLATTED, LASERED, BURNED and EXPLODED. For example, if a Terrorist dies due to being burned by fire, it explodes due to being BURNED. It is thus expected that when a Terrorist dies to anything resembling an explosion, it explodes. This was counterintuitively not the case for the explosion deaths of GLA Demo units.

Testing

Before

The enemy Terrorists die without detonating when Demo Jarmen Kell dies (not suicided)

BEFORE_EXP.mp4

After

The enemy Terrorists detonate and damage the Barracks when Demo Jarmen Kell dies (not suicided)

AFTER_EXP.mp4

[xezon]

Code correct. Documentation in INI would be good.

Side note: Maybe we should add sub faction labels like we have in the Committee repository.

[xezon]

Rationale text missing.