Skip to content

Draft: [IMP] therp owl timer#17

Open
KKamaa wants to merge 13 commits intomasterfrom
12537-OWL-Timer
Open

Draft: [IMP] therp owl timer#17
KKamaa wants to merge 13 commits intomasterfrom
12537-OWL-Timer

Conversation

@KKamaa
Copy link
Contributor

@KKamaa KKamaa commented Mar 18, 2026

Refactor timer from using Angular 1.x to OWL

@gjotten
Copy link
Contributor

gjotten commented Mar 19, 2026

@KKamaa this is already a massive PR so I'd prefer if we can keep the OWL changeover separate from the issue fixes for ease of review. I'd also prefer to have the issue fixes in separate PRs so we can do tests as well as reviews in isolation. That way we limit regressions.

@KKamaa
Copy link
Contributor Author

KKamaa commented Mar 19, 2026

@KKamaa this is already a massive PR so I'd prefer if we can keep the OWL changeover separate from the issue fixes for ease of review. I'd also prefer to have the issue fixes in separate PRs so we can do tests as well as reviews in isolation. That way we limit regressions.

ah ok cool got it but we will have then to merge what we have then I can individual make PRs in regards to the individual issues. Another is to commit per issue so that we track in one MR. Maybe we can see if we have an acceptable version, merge it then it acts the base branch for issue tracking MRs

The main files are popup-app.js and options-app.js the reset I will continue to structure them into their respective directories e.g libs

@gjotten
Copy link
Contributor

gjotten commented Mar 19, 2026

@thomaspaulb what say you, to me it makes sense to merge what we have as a relatively stable base, then individual PRs per issue from there.

I've been using the timer since yesterday's commit and core functionality holds up.

@KKamaa
Copy link
Contributor Author

KKamaa commented Mar 19, 2026

@gjotten I forgot to mention that in the src we have a "dist" folder which has the duplicate code and allows for custom browser specific changes that don't affect other browsers, currently we have firefox and chrome where if we have individual changes e.g UI in Firefox looks bad we do custom changes for firefox only without affecting other browsers.

@thomaspaulb
Copy link
Contributor

@KKamaa Please cleanup the commit history and I can merge

@gjotten I tested the addon and it works well, so I am OK with merging, just I would like to prioritize the first point of #26 which is the generation of the signed XPI, because otherwise in my Firefox I have to load manually the addon after each restart. They don't stick unless they are signed XPI's.

@gjotten
Copy link
Contributor

gjotten commented Mar 20, 2026

@KKamaa pipeline is green again, I am of a mind to have this merged in. Please at least refer to issue#s on commit so we can trace what we changed where. If tempo is less, maybe just do one PR per issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants